This repository was archived by the owner on Aug 5, 2025. It is now read-only.
Trace local graph and then replace nodes with DT's dispatch graph#460
Merged
Trace local graph and then replace nodes with DT's dispatch graph#460
Conversation
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
This was referenced Sep 15, 2022
Contributor
Author
|
land after pytorch/pytorch#84980 shows up in PT nightly |
aazzolini
reviewed
Sep 16, 2022
| args = tree_map(lambda n: node_to_obj[n], node.args) | ||
| kwargs = tree_map(lambda n: node_to_obj[n], node.kwargs) | ||
|
|
||
| out = operator_dispatch( |
Contributor
There was a problem hiding this comment.
So this is doing "concrete" tracing, where we're tracing based on a concrete DTensor. Is this just for testing purposes or do we want to actually rely on concrete tracing for the final solution?
Contributor
Author
There was a problem hiding this comment.
This is not yet tracing. It is getting the intermediate DTensor outputs, so that we know what DTensor specs to pass to the next operator. Tracing is on line 318, which only applies to local tensors.
Contributor
There was a problem hiding this comment.
Got it, yeah what I mean is that this corresponds to doing concrete tracing -- where you need the concrete tensors in order to propagate sharding.
…ith DT's dispatch graph" [ghstack-poisoned]
…h graph" [ghstack-poisoned]
…ith DT's dispatch graph" [ghstack-poisoned]
…h graph" [ghstack-poisoned]
…ith DT's dispatch graph" [ghstack-poisoned]
…h graph" [ghstack-poisoned]
…ith DT's dispatch graph" [ghstack-poisoned]
…h graph" [ghstack-poisoned]
…ith DT's dispatch graph" [ghstack-poisoned]
…h graph" [ghstack-poisoned]
…ith DT's dispatch graph" [ghstack-poisoned]
…h graph" [ghstack-poisoned]
Merged
…ith DT's dispatch graph" [ghstack-poisoned]
…h graph" [ghstack-poisoned]
…ith DT's dispatch graph" [ghstack-poisoned]
…h graph" [ghstack-poisoned]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):