Closed
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
Contributor
|
@jianyuh has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
Hi, @jianyuh. I found this PR is not merged. So pytorch/pytorch#93825 do not include this fix. |
Contributor
Contributor
Author
|
Hi, @jianyuh. I created a new updated FBGEMM PR pytorch/pytorch#93907 to include this fix. |
Member
|
Thanks @zhuhaozhe ! Just approved on PyTorch repo. |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Feb 2, 2023
To include pytorch/FBGEMM#1572 Pull Request resolved: #93907 Approved by: https://github.com/jianyuh
pytorch-bot bot
pushed a commit
that referenced
this pull request
Feb 26, 2026
Summary: Fix #1540 (comment). jianyuh Pull Request resolved: #1572 Reviewed By: mjanderson09 Differential Revision: D42914040 Pulled By: jianyuh fbshipit-source-id: 38d9efc71f6855df639f64656a85b8776cf2f982
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1540 (comment).
@jianyuh