Add kwargs to data dict #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For all bot-methods that are not decorated with `@message`
Member
Author
|
test_official will fail on 3.5 and 3.6 until #742 is merged |
tsnoam
approved these changes
Jul 24, 2017
Member
|
just waiting for travis to approve |
Member
Author
|
@tsnoam what's the difference by copying them? Also I just realised that it will be None if there are no kwargs. Is that a problem? |
Member
|
@Eldinnie 1. afaik it will always be a dict. an empty dict. |
This reverts commit 2ae9595.
Member
Author
|
Yes empty dict indeed |
Member
Author
|
Only expected test fail. Unfortunately there's not much we can do about the coverage drop... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all bot-methods that are not decorated with
@messagefixes #733