Skip to content

Remove Bot API Related Deprecations #3858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 37 commits into from
Sep 3, 2023
Merged

Remove Bot API Related Deprecations #3858

Bibo-Joshi merged 37 commits into from
Sep 3, 2023

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Aug 24, 2023 •
edited
Loading

@Bibo-Joshi Bibo-Joshi added ⚙️ bot-api affected functionality: bot-api 🛠 breaking change type: breaking labels Aug 24, 2023
github-actions[bot]
github-actions bot reviewed Aug 24, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

@Bibo-Joshi Bibo-Joshi changed the base branch from master to api-6.8 August 25, 2023 15:39
@Bibo-Joshi Bibo-Joshi marked this pull request as ready for review August 26, 2023 09:51
@Bibo-Joshi Bibo-Joshi added this to the v20.5 milestone Aug 26, 2023
harshil21
harshil21 requested changes Aug 28, 2023
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn that was a lot of code. Doc build is failing btw.

lemontree210
lemontree210 reviewed Sep 2, 2023
View reviewed changes
Copy link
Member

@lemontree210 lemontree210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing effort 👏🏻

telegram/_files/_basethumbedmedium.py
is supposed to be the same over time and for different bots.
Can't be used to download or reuse the file.
file_size (:obj:`int`, optional): File size.
thumb (:class:`telegram.PhotoSize`, optional): Thumbnail as defined by sender.
Copy link
Member

@lemontree210 lemontree210 Sep 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this snippet needs to be added before Args: here as well?

.. versionchanged:: NEXT.VERSION
      |removed_thumb_note|

Copy link
Member Author

@Bibo-Joshi Bibo-Joshi Sep 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I didn't bother b/c it's a private class. I don't really know why it has a docstring in the first place :D

Base automatically changed from api-6.8 to master September 3, 2023 11:43
@Bibo-Joshi Bibo-Joshi merged commit f9ccf56 into master Sep 3, 2023
@Bibo-Joshi Bibo-Joshi deleted the drop-api-6.7-deprecations branch September 3, 2023 12:23
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@lemontree210 lemontree210 lemontree210 left review comments

@harshil21 harshil21 harshil21 requested changes

@clot27 clot27 Awaiting requested review from clot27

Assignees

No one assigned

Labels

⚙️ bot-api affected functionality: bot-api 🛠 breaking change type: breaking

Projects

None yet

Milestone

v20.5

Development

Successfully merging this pull request may close these issues.

4 participants

@Bibo-Joshi @harshil21 @lemontree210