API 6.6 #3584

Bibo-Joshi · 2023-03-09T19:44:17Z

Checklist for PRs

Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
Created new or adapted existing unit tests
Documented code changes according to the CSI standard
Added myself alphabetically to AUTHORS.rst (optional)
Added new classes & modules to the docs and all suitable __all__ s

ToDo

All methods that accept the new InputSticker must be tested with local mode @harshil21
Uploading of InputSticker - To attach:// or not atttach:// tdlib/telegram-bot-api#375 : Double check if InputSticker should be uploaded via attach://
Update the deprecation project: https://github.com/python-telegram-bot/python-telegram-bot/projects/9#card-88599701

If the PR contains API changes (otherwise, you can delete this passage)

New classes:
- Added self._id_attrs and corresponding documentation
- __init__ accepts api_kwargs as kw-only
Added new shortcuts:
- In Chat & User for all methods that accept chat/user_id
- In Message for all methods that accept chat_id and message_id
- For new Message shortcuts: Added quote argument if methods accepts reply_to_message_id
- In CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id
If relevant:
- Added new constants at telegram.constants and shortcuts to them as class variables
- Link new and existing constants in docstrings instead of hard coded number and strings
- Add new message types to Message.effective_attachment
- Added new handlers for new update types
  - Add the handlers to the warning loop in the ConversationHandler
- Added new filters for new message (sub)types
- Added or updated documentation for the changed class(es) and/or method(s)
- Added the new method(s) to _extbot.py
- Added or updated bot_methods.rst
- Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION_INFO
- Added logic for arbitrary callback data in tg.ext.Bot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message

harshil21 · 2023-03-10T17:07:46Z

@marcosdodo please stop spamming, if you continue to do so, you'll be banned

telegram/_bot.py

I had implemented the renaming for `StickerSet only`

other tests are probably failing not due to me having changed something...

github-actions

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

telegram/_bot.py

telegram/_files/_basethumbedmedium.py

* add aliases to support calls to old methods * issue deprecation warning if an old method is called * WEIRD ERROR in `test_sticker_set_to_dict()` (see my TODO note there)

tests/auxil/bot_method_checks.py

the method will be removed anyway, no need to add new parameter to it.

the tests were passing because Bot API still supports the old method

telegram/request/_requestparameter.py

harshil21

phew! Huge update with lots of changes (mostly boilerplate 😞)..

I wonder if we could've gotten away with the renaming by just overriding __(set/get)attr__ in TelegramObject to detect the usage of deprecated parameters

telegram/_bot.py

telegram/_inline/inlinequeryresultmpeg4gif.py

telegram/_inline/inlinequeryresultphoto.py

tests/_files/test_sticker.py

tests/test_bot.py

tests/test_official.py

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>

This reverts commit b2cd7c2.

Poolitzer

LGTM

Bot(Short)Description & set/get_my(_short)_description

30e8d50

Bibo-Joshi added the ⚙️ bot-api affected functionality: bot-api label Mar 9, 2023

Bibo-Joshi and others added 2 commits March 9, 2023 20:45

Update contrib guide for NEXT.VERSION

8e8412f

Feat: Clarify how to deal with API deprecations

907d7ba

This comment was marked as spam.

Sign in to view

lemontree210 added 3 commits March 10, 2023 20:16

thumb->thumbnail: BaseThumbedMedium, Animation, send_animation

3a9b523

thumb->thumbnail: change warning text

c07a9b5

thumb->thumbnail: remove thumb from data in Bot.send_animation

6afff73

Bibo-Joshi commented Mar 10, 2023

View reviewed changes

telegram/_bot.py Outdated Show resolved Hide resolved

harshil21 and others added 11 commits March 11, 2023 02:28

New: Add 6 sticker methods

d8b95ad

add pytestmon to gitignore

eecf649

thumb->thumbnail: Audio and Bot.send_audio()

f80896a

Merge remote-tracking branch 'origin/api-6.6' into api-6.6

bb26fcb

thumb->thumbnail: Document and Bot.send_document()

37f509e

thumb->thumbnail: Sticker

6e83ddf

fix thumb->thumbnail: Sticker

bfb45a8

I had implemented the renaming for `StickerSet only`

minor: fix docstring

7e794a8

Sticker, StickerSet: fix some failing tests

6a84d26

other tests are probably failing not due to me having changed something...

deepsource

2bf8fd1

update Bot API version number

7c8a14f

github-actions bot reviewed Mar 11, 2023

View reviewed changes

Bibo-Joshi commented Mar 11, 2023

View reviewed changes

telegram/_bot.py Outdated Show resolved Hide resolved

telegram/_bot.py Outdated Show resolved Hide resolved

telegram/_files/_basethumbedmedium.py Outdated Show resolved Hide resolved

lemontree210 added 4 commits March 12, 2023 14:02

rename: Bot.set_sticker_set_thumb -> Bot.set_sticker_set_thumbnail

6f2f17d

* add aliases to support calls to old methods * issue deprecation warning if an old method is called * WEIRD ERROR in `test_sticker_set_to_dict()` (see my TODO note there)

Merge remote-tracking branch 'origin/api-6.6' into api-6.6

ec97456

Video, Bot.send_video(): thumb -> thumbnail

c2bcf30

* add aliases to support calls to old methods * issue deprecation warning if an old method is called * WEIRD ERROR in `test_sticker_set_to_dict()` (see my TODO note there)

remove unnecessary fixtures from added tests

0a7f2e8

Bibo-Joshi commented Mar 21, 2023

View reviewed changes

tests/auxil/bot_method_checks.py Show resolved Hide resolved

lemontree210 and others added 9 commits March 22, 2023 13:03

remove redundant comments

dd9820c

Merge remote-tracking branch 'origin/api-6.6' into api-6.6

d0ba2da

remove param thumbnail from old method set_sticker_set_thumb

39df3da

the method will be removed anyway, no need to add new parameter to it.

fix(call to Bot._post): setStickerSetThumb->setStickerSetThumbnail

963630c

the tests were passing because Bot API still supports the old method

Review: Modify docstring with constants and substitutions

f2ebfc5

Review: add a todo comment in a test file

682b25e

Update docs of sticker_type in createNewStickerSet

21190b9

successfully test set_custom_emoji_sticker_set_thumbnail

f20117d

use variable

608b370

Bibo-Joshi commented Mar 22, 2023

View reviewed changes

telegram/request/_requestparameter.py Outdated Show resolved Hide resolved

Improve coverage

ee57168

harshil21 requested changes Mar 22, 2023

View reviewed changes

Bibo-Joshi and others added 12 commits March 23, 2023 19:08

Apply "optional" doc fixes

49d33be

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>

gather in tests

2fc42ee

Add a CSI comment

ef95b11

fix: replace warn() in sticker.py and inputmedia.py

0967a8b

Merge remote-tracking branch 'origin/api-6.6' into api-6.6

4ba8893

Make stacklevel check more strict

c79ef6b

deprecations.py: remove the bit intended for decorator check

1a11075

add test for deprecation warning about Bot.set_sticker_set_thumb()

04bf1d4

rename function for checking args and attrs

94e700c

set_sticker_set_thumb depercations are harder that I'd like them to be …

65c2e13

One more small change

b2cd7c2

Revert "One more small change"

579da31

This reverts commit b2cd7c2.

Bibo-Joshi added this to the v20.2 milestone Mar 24, 2023

Poolitzer approved these changes Mar 25, 2023

View reviewed changes

Bibo-Joshi merged commit 512e390 into master Mar 25, 2023

Bibo-Joshi deleted the api-6.6 branch March 25, 2023 10:47

github-actions bot locked and limited conversation to collaborators Apr 2, 2023

API 6.6 #3584

API 6.6 #3584

Uh oh!

Conversation

Bibo-Joshi commented Mar 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist for PRs

ToDo

If the PR contains API changes (otherwise, you can delete this passage)

Uh oh!

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

harshil21 commented Mar 10, 2023

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

harshil21 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Poolitzer left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Bibo-Joshi commented Mar 9, 2023 •

edited

Loading