Check commands in commandhandler for args #3854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- check if has_args is negative, raise ValueError if True - removed Enum in favor of if else - added versionadded:: NEXT.VERSION - added more test cases
Contributor
Author
|
Adding @Bibo-Joshi for review pls 🙏 |
harshil21
requested changes
Aug 22, 2023
Member
harshil21
left a comment
There was a problem hiding this comment.
Thanks for the PR. I see that you've not fully resolved Hinrich's review comments, specifically the wording in the docstrings (#3812 (comment) & #3812 (comment)). Other than that, logic looks good and simple!
Bibo-Joshi
requested changes
Aug 22, 2023
harshil21
approved these changes
Aug 23, 2023
Bibo-Joshi
approved these changes
Aug 23, 2023
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thank you for the nice contribution :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, so sorry, i now realize #3812 is closed, but i have finished amending changes in this new PR here. So sorry for the delay 🙏 this should resolve the comments in the PR previously.
closes #3798, supersedes #3812