Skip to content

Remove version check from examples #3846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 2 commits into from
Aug 21, 2023
Merged

Remove version check from examples #3846

Bibo-Joshi merged 2 commits into from
Aug 21, 2023

Conversation

@harshil21
Copy link
Member

@harshil21 harshil21 commented Aug 17, 2023

Removes version check from examples because:

  • No one is running 20.0a0 anymore
  • that link doesn't work for v13 documentation
  • if a user is running the examples, they're likely a beginner and freshly installed the latest version of ptb

Ref #3820 (comment)

@harshil21 harshil21 added the ⚙️ examples affected functionality: examples label Aug 17, 2023
@harshil21 harshil21 added this to the v20.5 milestone Aug 17, 2023
@Bibo-Joshi Bibo-Joshi merged commit 58a109a into master Aug 21, 2023
@Bibo-Joshi Bibo-Joshi deleted the rm-version-check-examples branch August 21, 2023 16:47
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Bibo-Joshi Bibo-Joshi Bibo-Joshi approved these changes

Assignees

No one assigned

Labels

⚙️ examples affected functionality: examples

Projects

None yet

Milestone

v20.5

Development

Successfully merging this pull request may close these issues.

3 participants

@harshil21 @Bibo-Joshi