-
Notifications
You must be signed in to change notification settings - Fork 6k
Rework Pytest Integration into GitHub Actions #3776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I must say that I don't find the plug-in-less output (example here) less readible than the previously-working one (example here). Additionally, the summary thingy works quite nicely IMO: https://github.com/python-telegram-bot/python-telegram-bot/actions/runs/5369863913#summary-14534142641 |
Mh, that could be because I generated the failure report only on the "run last failures" run 🤔 |
Reading the code of the action it seems like they for the XML report Details<?xml version="1.0" encoding="utf-8"?>
<testsuites>
<testsuite errors="0" failures="1" hostname="fv-az1252-633" name="pytest" skipped="0" tests="1"
time="8.881" timestamp="2023-06-25T20:55:18.083387">
<testcase classname="tests.request.test_request.TestHTTP2WithRequest"
name="test_http_2_response" time="0.004"/>
<testcase classname="tests.request.test_request.TestHTTP2WithRequest"
name="test_http_2_response" time="0.003"/>
<testcase classname="tests.request.test_request.TestHTTP2WithRequest"
name="test_http_2_response" time="0.050">
<failure
message="AssertionError: assert 'HTTP/2' == 'HTTP/1' - HTTP/1 ? ^ + HTTP/2 ? ^">
self = <tests.request.test_request.TestHTTP2WithRequest object at
0x000001CD3B08BF08>
async def test_http_2_response(self):
httpx_request = HTTPXRequest(http_version="2")
async with httpx_request:
resp = await httpx_request._client.request(
url="https://python-telegram-bot.org",
method="GET",
headers={"User-Agent": httpx_request.USER_AGENT},
)
> assert resp.http_version == "HTTP/1"
E AssertionError: assert 'HTTP/2' == 'HTTP/1'
E - HTTP/1
E ? ^
E + HTTP/2
E ? ^
tests\request\test_request.py:96: AssertionError
</failure>
</testcase>
</testsuite>
</testsuites>the number of failures and tests is aggregated by parsing each An alternative output strategy would be to also include the results of the first run, but this leads to failures that repeat in the |
I agree that there is not much difference and that the summary view is very nice |
|
@lemontree210 @harshil21 may I understand your comments as approval, then? :) |
harshil21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, was just waiting for CI to show green checks )
mine yes, though not a very competent one 🙄 |


See #3769 (comment)