fix CI issue (_nonwrappers)
#3769
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_nowrappers)
Member
|
3.11 macos tests show passing even though there was an internal pytest error (looks like it was flaky, and not related to this PR). I believe it showed passing cause https://github.com/python-telegram-bot/python-telegram-bot/blob/master/.github/workflows/test.yml#L69 ran with no tests and then gave an exit code of 0. |
Member
|
Ah, the pleasures of using protected members 🫠 Replacing one protected member with another one doesn't sound overly desirable to me TBH. Is there a way to do wtih with proper public API? How terrible do the GitHub Actions logs look like if we remove this custom plugin all together? |
This was referenced Jun 25, 2023
Member
|
superseded by #3776 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plugin_github_group.py triggers exception when running CI tasks
AttributeError: '_HookCaller' object has no attribute '_nonwrappers'This attribute is indeed absent, however the attribute
._hookimplscontains the necessary keys.