Skip to content

Add some more ruff rules #3763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 6 commits into from
Jun 29, 2023
Merged

Add some more ruff rules #3763

Bibo-Joshi merged 6 commits into from
Jun 29, 2023

Conversation

@harshil21
Copy link
Member

@harshil21 harshil21 commented Jun 18, 2023 •
edited
Loading

@harshil21 harshil21 added the 🛠 code-quality change type: code-quality label Jun 18, 2023
@harshil21 harshil21 added this to the v20.4 milestone Jun 18, 2023
github-actions[bot]
github-actions bot reviewed Jun 18, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited the (optional) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the additional dependencies for the hooks in sync with the requirements :)

@github-actions github-actions bot removed the 🛠 code-quality change type: code-quality label Jun 18, 2023
@harshil21 harshil21 added the 🛠 code-quality change type: code-quality label Jun 18, 2023
@harshil21 harshil21 added the 📋 pending-review work status: pending-review label Jun 20, 2023
Bibo-Joshi
Bibo-Joshi reviewed Jun 25, 2023
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meta question: I guess you kept track of the changelog and added the new rules manually?

@harshil21
Copy link
Member Author

harshil21 commented Jun 25, 2023

Meta question: I guess you kept track of the changelog and added the new rules manually?

at first no, I went through the whole list again, but with the newer versions released since this PR, yes I tracked the changelog

@harshil21 harshil21 removed the 📋 pending-review work status: pending-review label Jun 25, 2023
@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Jun 25, 2023

Meta question: I guess you kept track of the changelog and added the new rules manually?

at first no, I went through the whole list again, but with the newer versions released since this PR, yes I tracked the changelog

Okay. I'm wondering if we can automate that a bit … or at least do that manually on dependabot PRs …

@harshil21
Review: ignore ruff on
62d765e 
'assert job==job
@harshil21
Copy link
Member Author

harshil21 commented Jun 25, 2023

Okay. I'm wondering if we can automate that a bit … or at least do that manually on dependabot PRs …

I'm okay with checking manually on dependabot PRs for now

Bibo-Joshi
Bibo-Joshi approved these changes Jun 25, 2023
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) let's wait for the master branch to work again before merging, though …

@Bibo-Joshi Bibo-Joshi added the 📋 do-not-merge-yet work status: do-not-merge-yet label Jun 25, 2023
@Bibo-Joshi Bibo-Joshi removed the 📋 do-not-merge-yet work status: do-not-merge-yet label Jun 26, 2023
@harshil21 harshil21 added the 📋 pending-merge work status: pending-merge label Jun 28, 2023
@Bibo-Joshi Bibo-Joshi merged commit 58b89cf into master Jun 29, 2023
@Bibo-Joshi Bibo-Joshi deleted the more-ruff-rules branch June 29, 2023 09:38
@Bibo-Joshi Bibo-Joshi removed the 📋 pending-merge work status: pending-merge label Jun 29, 2023
clot27 pushed a commit that referenced this pull request Jul 3, 2023
@harshil21
Add More ruff Rules (#3763)
1b2cc5b
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Bibo-Joshi Bibo-Joshi Bibo-Joshi approved these changes

Assignees

No one assigned

Labels

🛠 code-quality change type: code-quality

Projects

None yet

Milestone

v20.4

Development

Successfully merging this pull request may close these issues.

3 participants

@harshil21 @Bibo-Joshi