Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

Makes ExtBot.callback_data_cache readonly and optional. In particular, the CDC is now only instantiated if requested. This is a preparation for making the corresponding 3rd party dependency optional.
Also removes ExtBot.arbitrary_callback_data.

Checklist for PRs

  • [u] Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

@Bibo-Joshi Bibo-Joshi added 🛠 refactor change type: refactor 🛠 breaking change type: breaking labels Sep 30, 2022
@Bibo-Joshi Bibo-Joshi added this to the v20.0 milestone Sep 30, 2022
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last nitpick :)

@Bibo-Joshi Bibo-Joshi modified the milestones: v20.0, v20.0a5 Oct 6, 2022
@Bibo-Joshi Bibo-Joshi merged commit fb87418 into master Oct 7, 2022
@Bibo-Joshi Bibo-Joshi deleted the read-only-cdc branch October 7, 2022 08:18
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🛠 breaking change type: breaking 🛠 refactor change type: refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants