-
Notifications
You must be signed in to change notification settings - Fork 6k
Test python 3.11 & Change Enum Behaviour #3168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
3.11 tests are failing due to python/cpython#94601, which has been fixed and will be included in 3.11b5. Built docs locally without any issues. |
|
So the root cause of the bug might not have been the issue I linked, but the changed behavior when mixing Hence I adjusted the behavior for 3.11. Also noticed that we show the Enum value on |
|
About allowed failures: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idcontinue-on-error IISC that may lead to some unexpected UI stuff (community/community#15452, actions/runner#2347), but whatever … Regarding def pprint(arg: int | str) -> str:
return "Value is" + str(arg) # explicitly cast in case it's an intNow In any case
|
|
Waiting for actions/python-versions#183 to be merged so the 3.11 tests run... |
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. rerunning the failing tests (test-official fails b/c of the api update, ofc)
Tests if py 3.11 works with the lib or not (the Python team really wants everyone to test it out). Not to be merged atm.
Also changes:
__repr__to matchStringEnum's