Updating the examples #2937

Poolitzer · 2022-03-27T18:43:59Z

Checklist for PRs

Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
Created new or adapted existing unit tests
Added myself alphabetically to AUTHORS.rst (optional)
Added new classes & modules to the docs

If the PR contains API changes (otherwise, you can delete this passage)

New classes:
- Added self._id_attrs and corresponding documentation
- __init__ accepts **_kwargs
Added new shortcuts:
- In Chat & User for all methods that accept chat/user_id
- In Message for all methods that accept chat_id and message_id
- For new Message shortcuts: Added quote argument if methods accepts reply_to_message_id
- In CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id
If relevant:
- Added new constants at telegram.constants and shortcuts to them as class variables
- Added new handlers for new update types
- Added new filters for new message (sub)types
- Added or updated documentation for the changed class(es) and/or method(s)
- Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION
- Added logic for arbitrary callback data in tg.ext.Bot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message

Also put one logging line where it belongs

github-actions

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

Bibo-Joshi

Thanks for the PR! changes themself look good except for the pre-commit errors. would you mind adding this section back to the pre-commit config?

python-telegram-bot/.pre-commit-config.yaml

Lines 48 to 59 in d117d21

    
           -   id: mypy 
        
               name: mypy-examples 
        
               files: ^examples/.*\.py$ 
        
               args: 
        
                 - --no-strict-optional 
        
                 - --follow-imports=silent 
        
               additional_dependencies: 
        
                 - certifi 
        
                 - tornado>=6.1 
        
                 - APScheduler==3.6.3 
        
                 - cachetools==4.2.2 
        
                 - . # this basically does `pip install -e .`

I had removed it temporarily while working on the asyncio changes …

PS: Don't know why codecov complains - no tracked files changed

github-actions

Hey! Looks like you edited the (dev) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the pre-commit hook versions in sync with the dev requirements and the additional dependencies for the hooks in sync with the requirements :)

Poolitzer · 2022-03-31T07:24:52Z

I added the config and fixed the black thing. Black itself has currently an import issue in the pre-commit and pylint complains locally, so I forced git to commit anyway and am interested in how it runs here.

Poolitzer · 2022-03-31T07:46:15Z

I found the issue with black psf/black#2964, we either need to pin the click dependency to a lower version or upgrade the black version, what would you prefer and should I squeeze it in here or in a second PR?

harshil21 · 2022-03-31T07:50:08Z

@Poolitzer We're updating dependencies in #2925 so imo no need to do it here

PR #2925: Update Test Dependencies versions by harshil21

Bibo-Joshi · 2022-03-31T07:52:40Z

@harshil21 I'm okay with doing it here/in asyncio as the CI currently fails otherwise. #2925 is due only after asyncio

Poolitzer · 2022-03-31T07:53:45Z

@Bibo-Joshi So to be less disruptive, I could hardpin the dependency, and we remove the hardpin and upgrade the version in #2925

Bibo-Joshi · 2022-03-31T07:54:43Z

@Poolitzer sounds okay. please add a corresponding note to #2925

Bibo-Joshi

The changes themself LGTM 👍 did you by any chance already test the examples? if not: do you want to before we merge or do we just do that later?

Poolitzer · 2022-03-31T14:34:14Z

@Bibo-Joshi I didn't test it, I think that makes most sense before the first release.

examples/inlinebot.py

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>

harshil21 · 2022-03-31T18:02:25Z

Only thing I didn't run was passport, payment, and chatmemberbot. Rest all are working fine! Asyncio runs smooooth!

Resolved issues in examples/rawapibot.py via DeepSource Autofix

…xamples

examples/rawapibot.py

Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>

Poolitzer · 2022-04-06T19:23:24Z

looks good to me

Bibo-Joshi · 2022-04-10T08:05:40Z

Tested chatmemberbot. Runs fine except for a but in CMU.difference that I found (see #2947), but that's not due to the example.

Bibo-Joshi · 2022-04-10T13:45:50Z

Tested passport & payment example. For passports, I adjusted the html file a bit and found tdlib/telegram-bot-api#253 - which makes me want to stabilize Updater a bit more, but that's not for this PR.

If CI runs through & @harshil21 and @Poolitzer don't have anything to add, we can merge :)

harshil21 · 2022-04-10T13:52:14Z

All good from my side

Poolitzer · 2022-04-10T13:54:08Z

Looks good to me as well

Poolitzer added 2 commits March 25, 2022 13:41

Fix: await coroutines

06aa4c6

Also put one logging line where it belongs

Feat: switch all markdown mentions to hml

eeb4ce5

github-actions bot reviewed Mar 27, 2022

View reviewed changes

Bibo-Joshi added the ⚙️ examples affected functionality: examples label Mar 27, 2022

Bibo-Joshi added this to the v14 milestone Mar 27, 2022

Bibo-Joshi requested changes Mar 27, 2022

View reviewed changes

Poolitzer added 2 commits March 31, 2022 09:11

Feat: readd pre-commits for examples

1ac4809

Fix: Apply Black

99ac298

github-actions bot reviewed Mar 31, 2022

View reviewed changes

Fix: mypy caught wrong application definition

188a79c

Fix: missed contexttype

2d28f12

Fix: Temporarily fixing black dependency

c3eda6f

Poolitzer mentioned this pull request Mar 31, 2022

Update Test Dependencies versions #2925

Merged

8 tasks

Bibo-Joshi approved these changes Mar 31, 2022

View reviewed changes

harshil21 requested changes Mar 31, 2022

View reviewed changes

examples/inlinebot.py Outdated Show resolved Hide resolved

Poolitzer and others added 2 commits March 31, 2022 19:24

Fix: Remove markdown leftovers

4007fe0

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>

verify examples by running them

7ce6b78

Autofix issues in 1 file

bc955d3

Resolved issues in examples/rawapibot.py via DeepSource Autofix

harshil21 approved these changes Mar 31, 2022

View reviewed changes

harshil21 added 3 commits March 31, 2022 23:36

dont use my dev chat id

bcf0248

Merge remote-tracking branch 'origin/asyncio-examples' into asyncio-e…

9fd8e0d

…xamples

remove unused backslash from string

31d178e

Bibo-Joshi reviewed Mar 31, 2022

View reviewed changes

examples/rawapibot.py Outdated Show resolved Hide resolved

examples/rawapibot.py Show resolved Hide resolved

Apply suggestions from code review

411a5f0

Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>

Update passportbot.html, minor tweak in {passport, payment}bot.py

f5f2838

Bibo-Joshi merged commit 62fc4ff into asyncio Apr 10, 2022

Bibo-Joshi deleted the asyncio-examples branch April 10, 2022 13:54

github-actions bot locked and limited conversation to collaborators Apr 17, 2022

	- id: mypy
	name: mypy-examples
	files: ^examples/.*\.py$
	args:
	- --no-strict-optional
	- --follow-imports=silent
	additional_dependencies:
	- certifi
	- tornado>=6.1
	- APScheduler==3.6.3
	- cachetools==4.2.2
	- . # this basically does `pip install -e .`

Updating the examples #2937

Updating the examples #2937

Uh oh!

Conversation

Poolitzer commented Mar 27, 2022

Checklist for PRs

If the PR contains API changes (otherwise, you can delete this passage)

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Bibo-Joshi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Poolitzer commented Mar 31, 2022

Uh oh!

Poolitzer commented Mar 31, 2022

Uh oh!

harshil21 commented Mar 31, 2022

Uh oh!

Bibo-Joshi commented Mar 31, 2022

Uh oh!

Poolitzer commented Mar 31, 2022

Uh oh!

Bibo-Joshi commented Mar 31, 2022

Uh oh!

Bibo-Joshi left a comment

Choose a reason for hiding this comment

Uh oh!

Poolitzer commented Mar 31, 2022

Uh oh!

Uh oh!

harshil21 commented Mar 31, 2022

Uh oh!

Uh oh!

Uh oh!

Poolitzer commented Apr 6, 2022

Uh oh!

Bibo-Joshi commented Apr 10, 2022

Uh oh!

Bibo-Joshi commented Apr 10, 2022 • edited by harshil21 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

harshil21 commented Apr 10, 2022

Uh oh!

Poolitzer commented Apr 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Bibo-Joshi left a comment •

edited

Loading

Bibo-Joshi commented Apr 10, 2022 •

edited by harshil21

Loading