Skip to content

Conversation

@joesinghh
Copy link

My PR doesn't contain any point from below as it's fixing the grammatical errors in README.md.

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)

If the PR contains API changes (otherwise, you can delete this passage)

  • New classes:

    • Added self._id_attrs and corresponding documentation
    • __init__ accepts **_kwargs
  • Added new shortcuts:

    • In Chat & User for all methods that accept chat/user_id
    • In Message for all methods that accept chat_id and message_id
    • For new Message shortcuts: Added quote argument if methods accepts reply_to_message_id
    • In CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id
  • If relevant:

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Added new handlers for new update types
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION
    • Added logic for arbitrary callback data in tg.ext.Bot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message

@Bibo-Joshi Bibo-Joshi changed the base branch from master to doc-fixes October 3, 2021 08:48
@Bibo-Joshi Bibo-Joshi added the ⚙️ documentation affected functionality: documentation label Oct 3, 2021
@Bibo-Joshi
Copy link
Member

Thanks for the PR! I rebased to the doc-fixes branch where we gather documentation contributions. Please be sure to resolve the merge conflicts and to also apply the changes to README_RAW.rst

joesinghh and others added 3 commits October 3, 2021 14:34
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
@joesinghh
Copy link
Author

@Bibo-Joshi I resolved the conflict and made the required changes. I'll also make same changes into README_RAW.rst

@joesinghh
Copy link
Author

@Bibo-Joshi I have made grammatical changes into README_RAW.rst but I haven't added any extra section which was present in README.rst like Learning examples.

@joesinghh joesinghh requested a review from Bibo-Joshi October 3, 2021 09:30
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Just one nitpick left :)

@joesinghh
Copy link
Author

@Bibo-Joshi Done 👍🏻

@joesinghh joesinghh requested a review from Bibo-Joshi October 3, 2021 11:01
@Bibo-Joshi Bibo-Joshi merged commit 06480b5 into python-telegram-bot:doc-fixes Oct 3, 2021
Bibo-Joshi added a commit that referenced this pull request Oct 3, 2021
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2021
@harshil21 harshil21 added the hacktoberfest-accepted other: hacktoberfest-accepted label Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ documentation affected functionality: documentation hacktoberfest-accepted other: hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants