-
Notifications
You must be signed in to change notification settings - Fork 6k
Fixed grammatical errors in README.md #2691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR! I rebased to the doc-fixes branch where we gather documentation contributions. Please be sure to resolve the merge conflicts and to also apply the changes to |
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
|
@Bibo-Joshi I resolved the conflict and made the required changes. I'll also make same changes into |
|
@Bibo-Joshi I have made grammatical changes into |
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! Just one nitpick left :)
|
@Bibo-Joshi Done 👍🏻 |
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
My PR doesn't contain any point from below as it's fixing the grammatical errors in
README.md.Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)If the PR contains API changes (otherwise, you can delete this passage)
New classes:
self._id_attrsand corresponding documentation__init__accepts**_kwargsAdded new shortcuts:
Chat&Userfor all methods that acceptchat/user_idMessagefor all methods that acceptchat_idandmessage_idMessageshortcuts: Addedquoteargument if methods acceptsreply_to_message_idCallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idIf relevant:
telegram.constantsand shortcuts to them as class variablesREADME.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSIONtg.ext.Botfor new methods that either accept areply_markupin some form or have a return type that is/containstelegram.Message