Skip to content

Conversation

@harshil21
Copy link
Member

@harshil21 harshil21 commented Jun 6, 2021

for some reason pass_args=True was still being passed to a CommandHandler

@harshil21 harshil21 added the ⚙️ examples affected functionality: examples label Jun 6, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

@Bibo-Joshi
Copy link
Member

Maybe we can do this together with #2346?

@harshil21 harshil21 added the 📋 do-not-merge-yet work status: do-not-merge-yet label Jun 6, 2021
@harshil21 harshil21 added this to the v14 milestone Jun 7, 2021
@Poolitzer
Copy link
Member

Poolitzer commented Jun 7, 2021

I dont see the need, ou contraire. This example throws a warning, we should merge this asap to avoid bad code examples.

@Bibo-Joshi Bibo-Joshi merged commit d08172b into master Jun 7, 2021
@Bibo-Joshi Bibo-Joshi deleted the rm-deprecated-arg branch June 7, 2021 07:05
@Bibo-Joshi Bibo-Joshi removed the 📋 do-not-merge-yet work status: do-not-merge-yet label Jun 7, 2021
sakibguy added a commit to sakibguy/python-telegram-bot that referenced this pull request Jun 8, 2021
Remove Deprecated pass_args from Deeplinking Example (python-telegram-bot#2550)
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ examples affected functionality: examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants