-
Notifications
You must be signed in to change notification settings - Fork 6k
Stabilize some tests #2522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize some tests #2522
Conversation
|
There were many reasons why the game tests were failing -
Despite fixing this, there is still a chance that this can fail due to race conditions (many jobs running at once), so an Edit: Also removed an unnecessary game test. Onto the next test... |
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I admire your patience with the tests 👍
|
changes look good to me |
Tries to fix tests like:
First two will be fixed when the tests actually fail and the error is printed to console
Checks will be run many times to expose the failing ones