Skip to content

Conversation

@harshil21
Copy link
Member

@harshil21 harshil21 commented May 14, 2021

Tries to fix tests like:

Checks will be run many times to expose the failing ones

@harshil21 harshil21 added the ⚙️ tests affected functionality: tests label May 14, 2021
@harshil21
Copy link
Member Author

harshil21 commented May 15, 2021

There were many reasons why the game tests were failing -

  • Not using one single bot. This caused problems since different bots were keeping track of different scores across different tests... Scrap that, one bot is used across the entire session.
  • animation_file_id actually changes every time the game score is edited, but the tests were checking if they were the same...
  • @flaky on game tests were useless or actually made it more unstable as the same scores were being used, raising the error again.

Despite fixing this, there is still a chance that this can fail due to race conditions (many jobs running at once), so an xfail was added.

Edit: Also removed an unnecessary game test.

Onto the next test...

Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admire your patience with the tests 👍

@Poolitzer
Copy link
Member

changes look good to me

@Bibo-Joshi Bibo-Joshi merged commit 5ff3b76 into master May 19, 2021
@Bibo-Joshi Bibo-Joshi deleted the stability branch May 19, 2021 11:33
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ tests affected functionality: tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants