Update pre-commit settings #2415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
pre-commit setup worked in a clean venv for me, pylint fails though. |
Member
Author
also the pycharm auto-run thingy? what pylint fails do you get and how do you get them? (i.e. with |
Member
|
I did not use PyCharm's auto run thing, and I'm not 100% certain I know what you are referring to. I used pythons build-in venv module to create a venv inside the cloned repo (checked out the branch ofc), then activated it and ran I will paste the result from pylint in a minute. |
Member
|
long result incoming (python version is 3.9.2 btw): pylint output
|
Member
Author
|
Ah, that's due to pylint not working properly on py 3.8+ iirc. I'll check if buming to v2.7 helps. Otherwise I'll revert to having pre-commit run in it's own venv, where we can choose the python version. screenshot
that makes pycharm run the hooks before commiting and for me that results in an error message that pops up in the bottom right corner. |
Member
So you want me to check if I get the same error message? |
Member
|
apparently the environments dont install correctly there, I get an error as well: pre-commit output``` 13:41 Commit failed with error 0 file committed, 1 file failed to commit: this is a test [INFO] Installing environment for https://gitlab.com/pycqa/flake8. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/asottile/pyupgrade. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... black....................................................................Passed flake8...................................................................Passed pylint...................................................................Failed - hook id: pylint - exit code: 1 |
Member
Author
|
All right, so:
|
harshil21
reviewed
Mar 9, 2021
Member
harshil21
left a comment
There was a problem hiding this comment.
just some typos.
Btw when I ran pre-commit run -a in this branch locally, I still got this error for mypy:
mypy-ptb.................................................................Failed
- hook id: mypy
- exit code: 1
telegram/ext/utils/webhookhandler.py:126: error: Module has no attribute "WindowsProactorEventLoopPolicy"; maybe "AbstractEventLoopPolicy"? [attr-defined]
Found 1 error in 1 file (checked 136 source files)
Just confirming if you got this too, or is it only me?
Member
Author
|
@harshil21 Thanks! The mypy error you're seeing is due to you not running on Windows, IG. will add a |
harshil21
reviewed
Mar 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to improve pre-commit settings in order to close #2414 and #2410. A few notes:
message = cast(Message, update.message). IMO that would be too much for the examples, as not everyone actually uses a type checker