Skip to content

adding to_dict test #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tsnoam merged 1 commit into from
Oct 12, 2019
Merged

adding to_dict test #1544

tsnoam merged 1 commit into from
Oct 12, 2019

Conversation

@Poolitzer
Copy link
Member

@Poolitzer Poolitzer commented Oct 12, 2019

closes #1541

tsnoam
tsnoam approved these changes Oct 12, 2019
View reviewed changes
Copy link
Member

@tsnoam tsnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has the same problem like test_get_me_and_properties() though less severe.
we basically check the same object with itself. we need to use the "secret" environment variables for this test as well.
I will fix it with #1545

@tsnoam tsnoam merged commit 3545139 into python-telegram-bot:master Oct 12, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tsnoam tsnoam tsnoam approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Need unitest for Bot.to_dict()

2 participants

@Poolitzer @tsnoam