Skip to content

Add dispatcher argument to Updater #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tsnoam merged 10 commits into from
Jan 26, 2020
Merged

Add dispatcher argument to Updater #1484

tsnoam merged 10 commits into from
Jan 26, 2020

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Aug 27, 2019

This allows to pass a pre-initialized Dispatcher instance to Updater, closing #1407.

If the new dispatcher argument is used, attributes like bot and job_queue are fetched from the dispatcher rather than initializing them.
In the docstring tried to make clear that proper initialization of the dispatcher is up to the user, i.e. it is not checked if dispatcher.job_queue is not None.

Also added tests for creation with dispatcher. I hope those are enough …

@Eldinnie
Copy link
Member

Eldinnie commented Aug 28, 2019

Can you fix the open problems marked by CI?

@Bibo-Joshi
Copy link
Member Author

Bibo-Joshi commented Aug 28, 2019 •
edited
Loading

Fixed Flake8 and Codacy (by adding a property to Dispatcher). AFAICS the failed tests are due to test_official (i.e. missing API 4.4)

@Eldinnie
Copy link
Member

Eldinnie commented Sep 5, 2019

pre-commit still gives a flake8 error

Eldinnie
Eldinnie requested changes Sep 9, 2019
View reviewed changes
Copy link
Member

@Eldinnie Eldinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change requested

@Eldinnie
Copy link
Member

Eldinnie commented Sep 9, 2019

I'm also confused to why codecov isn;t running on this.

@jh0ker jh0ker added the 📋 pending-review work status: pending-review label Oct 11, 2019
@Eldinnie
Copy link
Member

Eldinnie commented Oct 15, 2019

We can ignore the codecov problem here. Ready to merge

@Eldinnie Eldinnie added 📋 pending-merge work status: pending-merge and removed 📋 pending-review work status: pending-review labels Oct 15, 2019
@Poolitzer Poolitzer added this to the 12.3 milestone Nov 11, 2019
@tsnoam tsnoam modified the milestones: 12.3, 12.5 Nov 15, 2019
@Bibo-Joshi Bibo-Joshi modified the milestones: 12.5, 12.4 Nov 22, 2019
@tsnoam tsnoam merged commit 883c6b5 into master Jan 26, 2020
@tsnoam tsnoam deleted the fix-1407 branch January 26, 2020 19:59
@Bibo-Joshi Bibo-Joshi mentioned this pull request Mar 3, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2020
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Eldinnie Eldinnie Eldinnie approved these changes

Assignees

No one assigned

Labels

🔌 enhancement pr description: enhancement 📋 pending-merge work status: pending-merge

Projects

None yet

Milestone

12.4

Development

Successfully merging this pull request may close these issues.

6 participants

@Bibo-Joshi @Eldinnie @jh0ker @tsnoam @Poolitzer