Skip to content

Fix #1328: custom timeout argument does not work #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jsmnbom merged 2 commits into from
Jan 30, 2019
Merged

Fix #1328: custom timeout argument does not work #1330

jsmnbom merged 2 commits into from
Jan 30, 2019

Conversation

@lorien
Copy link
Contributor

@lorien lorien commented Jan 23, 2019

No description provided.

@lorien lorien mentioned this pull request Jan 25, 2019
Closed
@jsmnbom
Copy link
Member

jsmnbom commented Jan 30, 2019

Thanks a lot for catching this :D
After testing locally it looks like we can ignore the CI errors (telegram changed some internal stuff once again sigh)
It also looks like this might actually fix #1323. I'll ask in the thread if others agree.
The changed test looks alright too, so I'm gonna go ahead and merge this as-is :) Good job :D

@jsmnbom jsmnbom merged commit 3e8d715 into python-telegram-bot:master Jan 30, 2019
@jsmnbom jsmnbom mentioned this pull request Jan 30, 2019
Closed
lvps added a commit to WEEE-Open/WEEEtofono that referenced this pull request Mar 25, 2019
@lvps
Updated dependencies with pre-release packages
18e22ed 
In a desperate attempt to get python-telegram-bot/python-telegram-bot#1330 and fix python-telegram-bot/python-telegram-bot#1323
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lorien @jsmnbom