Skip to content

Conversation

@JosXa
Copy link
Contributor

@JosXa JosXa commented Mar 16, 2018

Allows
url = helpers.create_deep_linked_url(bot.get_me().username, "Payload")

@jh0ker
Copy link
Member

jh0ker commented Mar 16, 2018

Looks good, but the example seems very convoluted. Do we really need 3 levels of deep linking to demonstrate how a single function works?

@JosXa
Copy link
Contributor Author

JosXa commented Mar 16, 2018

@jh0ker It's more about explaining what's possible with deep links and to spark the imagination a bit

@jh0ker
Copy link
Member

jh0ker commented Mar 16, 2018

Fair enough, but in that case perhaps you could make one of the levels use an inline button with a URL instead of just another text link

@JosXa
Copy link
Contributor Author

JosXa commented Mar 16, 2018

Good point

Copy link
Member

@jsmnbom jsmnbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a nice utility to have to me :D
I added a few comments though :)

@tsnoam
Copy link
Member

tsnoam commented May 7, 2018

@JosXa
What is the status of this PR? ( @bomjacob requested certain changes)

@JosXa
Copy link
Contributor Author

JosXa commented Oct 30, 2018

Currently not having the time to fix it up. Anyone else interested in getting the kudos for this contribution? @bomjacob

@Bibo-Joshi
Copy link
Member

Brought this PR up to date and implemented the requested changes.
Also made it possible create startgroup deep linking urls using @JosXa s new helpers method

@tsnoam tsnoam merged commit ccf5e6c into master Sep 13, 2019
@tsnoam tsnoam deleted the deeplinking-tools branch September 13, 2019 19:09
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2020
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔌 enhancement pr description: enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants