Do not support using test-image-results to upload images after test failures #7739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbliii
added a commit
to lbliii/bengal
that referenced
this pull request
Dec 23, 2025
…sing sequential generation Root cause: Pillow's C extensions are not thread-safe without the GIL. Python 3.14t (free-threading build) disables the GIL, causing segfaults when ThreadPoolExecutor is used for parallel image generation. Changes: - Remove ThreadPoolExecutor parallel generation (unsafe in no-GIL mode) - Add _is_free_threading() check to detect free-threading Python - Use sequential generation for all Python builds (consistent, safe) - Add progress logging for large sites (>100 pages) - Performance: ~30ms/card, acceptable for 1000+ page sites See: python-pillow/Pillow#7739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use test-image-results to upload images after test failures.
Suggested in #7733 (comment)