Consider palette size when converting and in getpalette()#6060
Merged
hugovk merged 2 commits intopython-pillow:mainfrom Feb 18, 2022
Merged
Consider palette size when converting and in getpalette()#6060hugovk merged 2 commits intopython-pillow:mainfrom
hugovk merged 2 commits intopython-pillow:mainfrom
Conversation
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Feb 20, 2022
This was referenced Sep 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6046
Investigating the issue, I think it can be stated as two problems.
getpalette()returns more entries than set byputpalette().This PR solves this by adding a
sizemember to the CImagingPaletteInstance.Fixing this removes the need for trimming the palette in Python in
im.load().