Skip to content

Ensure duplicated file pointer is closed #5946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 1 commit into from
Jan 10, 2022
Merged

Ensure duplicated file pointer is closed #5946

hugovk merged 1 commit into from
Jan 10, 2022

Conversation

@radarhere
Copy link
Member

@radarhere radarhere commented Jan 9, 2022

Resolves #5936. Ensures that the file pointer duplicated in TiffImagePlugin is closed, rather than counting on libtiff to do it.

Pillow/src/PIL/TiffImagePlugin.py

Lines 1186 to 1188 in eff6c34

# libtiff closes the file descriptor, so pass in a dup.
try:
fp = hasattr(self.fp, "fileno") and os.dup(self.fp.fileno())

I haven't added a test for this, since the issue involves hitting the limit on the number of open files.

@radarhere radarhere mentioned this pull request Jan 9, 2022
Closed
@hugovk hugovk merged commit ac7f42c into python-pillow:main Jan 10, 2022
@radarhere radarhere deleted the file_pointer branch January 10, 2022 05:39
@radarhere radarhere mentioned this pull request Mar 5, 2023
Merged
radarhere added a commit to radarhere/Pillow that referenced this pull request May 21, 2023
@radarhere
Removed fix from python-pillow#5946
716e0e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

File Closing TIFF

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OSError: [Errno 24] Too many open files for image.save for tiff images

2 participants

@radarhere @hugovk