Skip to content

Added specific error if path coordinate type is incorrect #5942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 1 commit into from
Jan 8, 2022
Merged

Added specific error if path coordinate type is incorrect #5942

hugovk merged 1 commit into from
Jan 8, 2022

Conversation

@radarhere
Copy link
Member

@radarhere radarhere commented Jan 8, 2022

Resolves #5939

When drawing a rectangle,

from PIL import Image, ImageDraw
im = Image.new("RGB", (1, 1))
draw = ImageDraw.Draw(im)
draw.rectangle((0, 0, 1, 1))

if the wrong coordinate type is used,

from PIL import Image, ImageDraw
im = Image.new("RGB", (1, 1))
draw = ImageDraw.Draw(im)
draw.rectangle(('0', '0', '1', '1'))

the error given is

Traceback (most recent call last):
  File "demo.py", line 4, in <module>
    draw.rectangle(('0', '0', '1', '1'))
  File "PIL/ImageDraw.py", line 259, in rectangle
    self.draw.draw_rectangle(xy, ink, 0, width)
SystemError: new style getargs format but argument is not a tuple

The issue points out that this is not terribly clear. Instead, this PR changes it to

Traceback (most recent call last):
  File "demo.py", line 4, in <module>
    draw.rectangle(('0', '0', '1', '1'))
  File "PIL/ImageDraw.py", line 279, in rectangle
ValueError: incorrect coordinate type

I also reduce some duplicate code at the same time.

@radarhere radarhere mentioned this pull request Jan 8, 2022
Closed
@hugovk hugovk merged commit eff6c34 into python-pillow:main Jan 8, 2022
@radarhere radarhere deleted the error branch January 8, 2022 21:55
@radarhere radarhere mentioned this pull request Jan 17, 2022
Closed
@radarhere radarhere changed the title Added specific error if ImagePath coordinate type is incorrect Added specific error if path coordinate type is incorrect Feb 10, 2022
radarhere added a commit to radarhere/Pillow that referenced this pull request Feb 10, 2022
@radarhere
Added release notes for python-pillow#5942
169ecc3
radarhere added a commit to radarhere/Pillow that referenced this pull request Feb 10, 2022
@radarhere
Added release notes for python-pillow#5942
9122962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Misleading error message when passing tuple of incorrect data type to ImageDraw methods

2 participants

@radarhere @hugovk