Skip to content

Bigendian Fixes#388

Merged
wiredfool merged 12 commits intopython-pillow:masterfrom
wiredfool:bigendian
Oct 22, 2013
Merged

Bigendian Fixes#388
wiredfool merged 12 commits intopython-pillow:masterfrom
wiredfool:bigendian

Conversation

@wiredfool
Copy link
Copy Markdown
Member

@wiredfool wiredfool commented Oct 22, 2013

Fixes for images on bigendian machines. Fixes #385

  • Image formats were incorrect for I;16 for converting to numpy.
  • That exposed issues where tiffs from libtiff were put in native byte order, and native tiffs were in image byte order.
  • Save tests were failing due to metadata issues, which are also fixed. Probably fixes Save RGB Tiff using LibTiff raises exception #387, needs tests for that.

Undone, and worth checking out in the future: I;32 and F;16/32 formats, as well as I;16S.

@wiredfool
I;16 images are little endian, not native endian
175c572
@wiredfool
uint16 varies from platform to platform, <u2 is spefific
366f9a5
@wiredfool
Tests for endian issues in decoding 16bit tif images
1945fec
@wiredfool
MM and II 16 bit integer tiffs unpack properly using libtiff on bigen…
6f8d968 
…dian platform
@wiredfool
MM and II 16 bit integer tiffs pack/write properly using libtiff on b…
3128a76 
…igendian platform
@wiredfool
py3k
8d21ce1
@wiredfool
Tag issues with libtiff -- Need to parse the tuples for the ifd and t…
32e2f97 
…he im.ifd. getattr + default for the im.ifd instead of silent try/except
@wiredfool
rm debugging print
8655209
@wiredfool
correcting debugging strings
c41a9b2
@wiredfool
whitespace error
758da6c
@wiredfool
String attr test case
6357b47
@wiredfool
final pass through atts: handling single rational tuple, using isStri…
6a0516d 
…ngType, flattening from single element tuple to string or int
@manisandro
Copy link
Copy Markdown
Member

manisandro commented Oct 22, 2013

Thanks a lot for looking at this! Could you also add the new test images?

  • Tests/images/12bit.deflate.tif
  • Tests/images/12bit.MM.deflate.tif
  • Tests/images/12bit.MM.cropped.tif

Also, I get before the test summary:

=== remaining temporary files
/tmp/pillow-tests/temp_file_libtiff_0.png
/tmp/pillow-tests/temp_file_libtiff_4.tif
/tmp/pillow-tests/temp_file_libtiff_2.png
/tmp/pillow-tests/temp_file_libtiff_6.tif
/tmp/pillow-tests/temp_file_libtiff_3.png
/tmp/pillow-tests/temp_file_tiff_0.tif
/tmp/pillow-tests/temp_file_libtiff_5.png
/tmp/pillow-tests/temp_file_libtiff_1.png

@wiredfool
Copy link
Copy Markdown
Member Author

wiredfool commented Oct 22, 2013

The images should have been added in 1945fec. I'm guessing that the remaining temp files might be from missing that.

@manisandro
Copy link
Copy Markdown
Member

manisandro commented Oct 22, 2013

Hmpf sorry, somehow missed that.

@manisandro
Copy link
Copy Markdown
Member

manisandro commented Oct 22, 2013

Hurray, builds successful on all Fedora arches. Thanks again!

wiredfool added a commit that referenced this pull request Oct 22, 2013
@wiredfool
Merge pull request #388 from wiredfool/bigendian
9f6c465 
Bigendian Fixes
@wiredfool wiredfool merged commit 9f6c465 into python-pillow:master Oct 22, 2013
@wiredfool
Copy link
Copy Markdown
Member Author

wiredfool commented Oct 22, 2013

Yay! Thanks for the acct on the ppc machine.

@wiredfool wiredfool mentioned this pull request Oct 22, 2013
Closed
@wiredfool wiredfool deleted the bigendian branch October 22, 2013 23:08
@hugovk hugovk mentioned this pull request Oct 25, 2014
Closed
@hugovk hugovk added the Big-endian Big-endian processors label Dec 18, 2019
radarhere pushed a commit to radarhere/Pillow that referenced this pull request Sep 24, 2023
@hugovk
Merge pull request python-pillow#388 from radarhere/32bit
b1f01c0 
Removed 32-bit wheels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Big-endian Big-endian processors

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Save RGB Tiff using LibTiff raises exception bug: tobytes() byteorder with multibyte samples, bigendian

3 participants

@wiredfool @manisandro @hugovk