Save arbitrary tags in Tiff image files#369
Merged
aclark4life merged 21 commits intopython-pillow:masterfrom Nov 30, 2013
Merged
Save arbitrary tags in Tiff image files#369aclark4life merged 21 commits intopython-pillow:masterfrom
aclark4life merged 21 commits intopython-pillow:masterfrom
Conversation
Member
Author
|
Likely before merging, we should have:
|
Member
|
It's probably OK to introduce a breaking change here, maybe @cgohkle or @d-schmidt can say more |
…ge, so spurious test failure.
Member
Author
|
Updated the merge, Resolved the test failure. |
Member
|
Still "We can’t automatically merge this pull request." here FWIW |
Member
Author
|
Ok, something must have changed in the last month since the last merge. I'll remerge. |
Member
Author
|
Ok, merge is clean now. |
aclark4life
added a commit
that referenced
this pull request
Nov 30, 2013
Save arbitrary tags in Tiff image files
This was referenced Aug 8, 2019
radarhere
pushed a commit
to radarhere/Pillow
that referenced
this pull request
Sep 24, 2023
Updated freetype to 2.13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #290, #291.
Warning: ce0e8b6 introduces an internal changes that affects one other file in Pillow, and potentially elsewhere if people are accessing the raw, undecoded data in ImageFileDirectory.tagdata. It used to store a tuple of type, data. Now it's just data, since there's another dict with the type information. See the big comment for the ImageFileDirectory class. I think it makes sense to change, but it's not essential.
Tests to exercise the tag writing code exposed many little bugs here, both in the libtiff and python code paths. There is a good chance that there's still some silliness with nested tuples somewhere, but we'll see on that.