Is it possible to backport all Pillow changes back to olefile?

Most of the changes look ok, except a couple (4c5d4bf and 082a311): olefile should not rely on other Pillow modules (i.e. PIL._binary and _util) because it is also used as a standalone package by several other projects. This is only for a few small functions, so I would prefer to keep the code as-is for i8, i16, i32 and isPath.

Apart from that, I am ok to backport the rest upstream.

Because olefile is now installable via PyPI, should Pillow install it as a dependency instead?

It'd make version updating much simpler, but what are the other benefits and drawbacks?

@hugovk Probably not, unless Pillow could not be installed without it. How about removing it completely from Pillow and documenting pip install olefile? That would be the first step toward possibly including olefile in Pillow's install_requires. Aside from being unable to read/write Microsoft OLE2 files, is there any other reason to keep OleFile code in Pillow? (Sorry to answer your questions with more questions 😄)

Coverage decreased (-0.2%) to 74.86% when pulling dfb1248 on radarhere:olefileio_upgrade into 8f0dca2 on python-pillow:master.

@radarhere Please can you remove those things #1226 (comment) so standalone olefile isn't dependent on Pillow?

Sure thing. I've now removed those commits. However, I have also updated the methods so that Python performs the endian tasks as with the current version of _binary.

Thank you!