Make OleFileIO VT dict building more comprehensive#1139
Make OleFileIO VT dict building more comprehensive#1139vperron wants to merge 1 commit intopython-pillow:masterfrom Polyconseil:master
Conversation
Also is more resilient to a weird RuntimeError upon iteration sometimes yielded in tests.
|
Looks good, I will test it and merge it upstream into olefile (http://www.decalage.info/olefile) |
|
I would be interested in details about the RuntimeError you mentioned, if there is any issue I need to fix in olefile. |
|
Well the runtime error did happen in a non-easily reproducible way and was about the vars() dictionary being modified upon iteration. That's why I refer to it as a style fix. |
|
@decalage2 Let us know if you merge it upstream as is, and we can just hit the merge button here. |
|
@decalage2 Any progress on this? |
|
Given that it's been a while, and that substantial changes to OleFileIO have already been merged with #1226, is it time to merge this? |
|
I think we need to hear from @decalage2 and if we don't, decide if we want to merge anyway… or not. I'm not exactly sure what's appropriate or needed. |
|
With the merging of #2199, this is no longer applicable. |
Mainly a style fix.