fix: rename period to interval in repr and tests#757
Merged
Secrus merged 1 commit intopython-pendulum:masterfrom Oct 24, 2023
Merged
fix: rename period to interval in repr and tests#757Secrus merged 1 commit intopython-pendulum:masterfrom
Secrus merged 1 commit intopython-pendulum:masterfrom
Conversation
CodSpeed Performance ReportMerging #757 will degrade performances by 19.12%Comparing Summary
Benchmarks breakdown
|
Secrus
approved these changes
Oct 24, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @sdispater @Secrus!
This PR renames the remaining mentions of
period/Periodtointerval/Interval, where it makes sense.PeriodtoIntervalinInterval.__repr__ValueErrormessage ofInterval.__new__Intervalperiodtointerval(mostly in tests) for a more consistent codebase. I left thedocsuntouched.A quick
rgsearch will show the only mentions left ofperiod/Periodare indocs/,formatting/,locales/,CHANGELOG.mdorclockPS: Thanks for the great library! I have relied on it a lot, both for professional and personal projects.
PPS: I have some free time on my hands in the next couple of months and would happily contribute more, if you guys have any suggestions.
Pull Request Check List
AddedUpdated tests for changed code.