Skip to content

Fix the release workflow#740

Merged
sdispater merged 2 commits intomasterfrom
fix/release-workflow-2
Aug 17, 2023
Merged

Fix the release workflow#740
sdispater merged 2 commits intomasterfrom
fix/release-workflow-2

Conversation

@sdispater
Copy link
Copy Markdown
Collaborator

@sdispater sdispater commented Aug 17, 2023

For the release workflow to work, we need to install the Rust toolchain first on some platforms and we need to use Python 3 to fix the wheels for MacOS arm wheels.

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@Secrus
Copy link
Copy Markdown
Collaborator

Secrus commented Aug 17, 2023

what about linux aarch64 wheels? maybe we could copy coverage setup? https://github.com/nedbat/coveragepy/blob/c2b238e86cade2e6163b24656a7d0549f4508e8f/.github/workflows/kit.yml#L101

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Aug 17, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #740 will not alter performance

Comparing fix/release-workflow-2 (d4599aa) with master (c2cfe19)

Summary

✅ 2 untouched benchmarks

@sdispater
Copy link
Copy Markdown
Collaborator Author

sdispater commented Aug 17, 2023

@Secrus We can always add the aarch64 architecture but I don't know if we will need the same fixes as the ones needed for MacOS due to python-poetry/poetry#7107.

@Secrus
Copy link
Copy Markdown
Collaborator

Secrus commented Aug 17, 2023

@sdispater I just thought it's worth adding and checking since you are already working on the release pipeline. Especially since there was a PR/request for that architecture for some time now: #517 #521

@sdispater
Copy link
Copy Markdown
Collaborator Author

sdispater commented Aug 17, 2023

I added the aarch64 architecture for Linux build. We'll see how it goes.

@sdispater sdispater merged commit d1a874d into master Aug 17, 2023
@sdispater sdispater deleted the fix/release-workflow-2 branch August 17, 2023 23:23
@edgarrmondragon
Copy link
Copy Markdown
Contributor

edgarrmondragon commented Aug 23, 2023 •
edited
Loading

Since pendulum now seems to use maturin to build wheels, did you folks consider using the auto-generated CI build workflow?

maturin generate-ci github > .github/workflows/CI.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sdispater @Secrus @edgarrmondragon