Make day of week convention more consistent across the codebase#731
Merged
Make day of week convention more consistent across the codebase#731
Conversation
CodSpeed Performance ReportMerging #731 will not alter performanceComparing Summary
|
c790854 to
2aff736
Compare
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the beginning, Pendulum had the convention that a week starts on Monday since it's the most common case and matches the ISO standard. However there were a few places where this convention was to enforced:
day_of_weekpropertydanddotokens when formatting a datetime instance.This PR makes sure everything is consistent across the codebase. Unfortunately, this makes this change a breaking one since this changes the behavior of the elements mentioned above.
The new
eandeotokens have been introduced to get the day of week but localized base on theweek_dataof the locale files.Fixes #683
Pull Request Check List