Update typing comments and add py.typed for PEP-561 compliance#320
Merged
sdispater merged 2 commits intopython-pendulum:masterfrom Mar 6, 2020
Merged
Update typing comments and add py.typed for PEP-561 compliance#320sdispater merged 2 commits intopython-pendulum:masterfrom
sdispater merged 2 commits intopython-pendulum:masterfrom
Conversation
0cb7d12 to
77f9561
Compare
|
This looks great! Any estimate on when it might make it in? I'm stubbing what I need right now but it would great to have the full type annotations. |
6106458 to
a9996e0
Compare
a9996e0 to
c42734f
Compare
|
Hello people, is there any chance we can get this forward? |
Collaborator
|
Thanks! |
Merged
elemoine
reviewed
Mar 13, 2020
|
|
||
|
|
||
| def parse(text, **options): | ||
| def parse(text, **options): # type: (str, **typing.Any) -> str |
There was a problem hiding this comment.
Is the return type really str? I am not familiar with the pendulum code base, but this looks suspicious to me.
There was a problem hiding this comment.
I believe the correct return type is typing.Union[pendulum.Date, pendulum.Time, pendulum.Duration].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.