Add RU locale#228
Merged
sdispater merged 4 commits intopython-pendulum:masterfrom May 21, 2019
senpos:ru-locale
Merged
Conversation
Contributor
Author
|
Due to the Changelog: Is it now required for translations as well? As I can see, not all current translations use this feature, but it is quite easy to implement with: translations = {
...
'units': {
'few_second': 'a few seconds'
},
...Am I right? |
Contributor
Author
|
Hello. Do I have to change something here, so you could merge it? The only failing thing is |
Merged
|
@sdispater |
|
Any chance of it to be merged? @sdispater why are you asking for locale contribution and then do not accept them for almost a year? |
Collaborator
|
Thanks! And sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #227
locale.pygenerated withclockon Windows 10.Tests are included.
Tested by me on Windows 10 with Python 3.6.4.
Thanks to @creazero for testing on Kubuntu 17.10 with Python 2.7 and 3.6.3.
Seems to be working fine. If you encounter any problems - feel free to update related issue or this PR.