Unique types for sentinel objects#11
Closed
RazerM wants to merge 1 commit intopython-hyper:masterfrom
Closed
Conversation
Current coverage is 100% (diff: 100%)@@ master #11 diff @@
===================================
Files 20 20
Lines 867 868 +1
Methods 0 0
Messages 0 0
Branches 169 169
===================================
+ Hits 867 868 +1
Misses 0 0
Partials 0 0
|
Member
|
See also #18, which is this PR + a somewhat wacky trick added. |
Member
|
#18 is merged, so closing this. |
This was referenced Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed solution to #8.
In this implementation, an empty
Sentinelclass replaces the existing one, which unique sentinel types then inherit from (so thatConnection.next_eventcan still check whether an event is an instance ofSentinel).A
make_sentinelfunction is added to create the type and return an instance.