Conversation
Done by passing `squeeze=True` to `step_response`.
We should add an appropriate examples_test.py like we do in Slycot |
|
We have a script Changes all look fine. I think fixed a few of these in some of my pending PR's (I remember a conversation → conversion conversion at some point), so we may get some small merge conflicts. @roryyorke Do you want to add the |
|
I'm happy to do it, though I'll only get to it the weekend starting 30 Jan.
…On Mon, 25 Jan 2021, 00:36 Richard Murray, ***@***.***> wrote:
We have a script examples/run_examples.py that will run all examples and
check for errors. We just need to put that at the end of workflow. Perhaps
this can/should go in the slycot-from-src workflow just as an independent
check that we haven't accidentally broken anything?
Changes all look fine. I think fixed a few of these in some of my pending
PR's (I remember a conversation → conversion conversion at some point), so
we may get some small merge conflicts.
@roryyorke <https://github.com/roryyorke> Do you want to add the
run_examples.py check in this PR or hold for a different one (it is note
quite related, but since you pointed it out...).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#518 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA3C7U7JPFCF5EH5DFLHSDS3SOHPANCNFSM4WQQFBZQ>
.
|
Some minor fixes, mostly to examples.
I guess the examples aren't run as part of CI? examples/run_examples.sh was supposed to help with that.