Consistent return values for lqe and lqr#477
Merged
murrayrm merged 10 commits intopython-control:masterfrom Dec 26, 2020
Merged
Consistent return values for lqe and lqr#477murrayrm merged 10 commits intopython-control:masterfrom
murrayrm merged 10 commits intopython-control:masterfrom
Conversation
…c style fixes + PEP8
…trol into lqe-consistent-lqr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #418 by making the return values for
lqeconsistent with those oflqr(andcareanddare). Specifically, the list of returned eigenvalues is a 1D array rather than being converted to a 2D array or matrix (depending on config settings).Resolves #418.