Stability margins for discrete time systems#469
Stability margins for discrete time systems#469bnavigator merged 4 commits intopython-control:masterfrom
Conversation
sawyerbfuller
left a comment
There was a problem hiding this comment.
Very nice, Looks good to me. Not sure why the previous author used an arcane incantation rather than just numpy.polyval in _poly_iw(), but maybe there is a numeric justification when working with imaginary arguments that I don’t know about.
I don’t have any good ideas for an analytic solution to the optimization problem.
Both yours / @repagh's and @swaldherr's (is there a more current GitHub handle?) implementations are very similar. They split the polynomials up into real and imaginary parts after applying |
c05e179 to
ad0a225
Compare
|
I think this should go into 0.8.4. It enhances functionality, but does not change the API and it fixes the bug that it returns wrong results with discrete input. |
My attempt to fix #465
If someone has an idea how to solve
min |1 + num(z) / den(z) |withz=exp(i w dt)analytically, that would be great. I opted for a numerical optimization instead.