Extract use_alias from converter by default#660
Merged
Tinche merged 10 commits intopython-attrs:mainfrom Jun 26, 2025
Merged
Conversation
AdrianSosic
commented
Jun 24, 2025
3515bf7 to
df95f3e
Compare
AdrianSosic
commented
Jun 24, 2025
df95f3e to
29f6adb
Compare
Member
|
Looks good, don't forget the changelog entry. |
AdrianSosic
commented
Jun 24, 2025
AdrianSosic
commented
Jun 24, 2025
Tinche
requested changes
Jun 25, 2025
Member
Tinche
left a comment
There was a problem hiding this comment.
We will also need a small test that tests the value is actually taken from the converter. Maybe in test_converters?
AdrianSosic
commented
Jun 25, 2025
Member
|
Changelog looks good, I always set it to unreleased too. |
AdrianSosic
added a commit
to emdgroup/baybe
that referenced
this pull request
Jun 25, 2025
Tinche
approved these changes
Jun 25, 2025
Member
|
Great job, thanks! |
AdrianSosic
added a commit
to emdgroup/baybe
that referenced
this pull request
Jul 2, 2025
AdrianSosic
added a commit
to emdgroup/baybe
that referenced
this pull request
Jul 2, 2025
AdrianSosic
added a commit
to emdgroup/baybe
that referenced
this pull request
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #596, adds a
use_aliasargument toConverter(similar to `forbid_extra_keys') whose value is taken as default when structuring/unstructuring without specifying the corresponding argument to the method calls.