Use inline table syntax for license key#58
Merged
hauntsaninja merged 1 commit intopython:mainfrom Jul 15, 2022
Merged
Conversation
This fixes a problem with old pip version that use an outdated TOML parser. Closes: python#57
JelleZijlstra
approved these changes
Jul 15, 2022
Member
JelleZijlstra
left a comment
There was a problem hiding this comment.
Do you think this is worth a hotfix release?
Collaborator
Author
|
I think this only relevant when pip installing the .tar.gz or from source, not when installing the wheel or from pypi, so I'm not sure how relevant this is. Also, I'm not sure if I'm right. :) |
hauntsaninja
approved these changes
Jul 15, 2022
Collaborator
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks for figuring this one out! Pretty sure you're right, pip used to use pytoml, which only supports TOML 0.4. Dotted keys were a feature of 0.5
|
sorry, unrelated |
|
the default python pip of debian 10 is took down by this minor issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem with old pip version that use an outdated TOML
parser.
Closes: #57