Merged
Conversation
Collaborator
Considering these are two quite separate concerns, I think this should be split in to two PRs. That said, I'm +0 on using ruff here for the reason you outlined: Ensuring that the linter tools don't use typing-extensions. (Although I still have reservations against using ruff for Python infrastructure projects. But considering the state of flake8, it's not an easy choice.) |
Member
Author
sure |
srittau
reviewed
May 28, 2024
srittau
approved these changes
May 28, 2024
Collaborator
srittau
left a comment
There was a problem hiding this comment.
LGTM, although I'd like @JelleZijlstra's opinion.
JelleZijlstra
approved these changes
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obviously I work at Astral, so I'm biased -- but I do think using linting tools written in another language is a particularly good fit for us at
typing_extensions. Most linters (including many flake8 plugins) can't really be installed into the same environment you'd want to use locally for testingtyping_extensions, as it's pretty hard to find a linter written in Python that doesn't depend (directly or indirectly) ontyping_extensions. If you then use the same environment to run tests as you used for running the linter, you're never sure whether you're actually testing your local copy oftyping_extensionsor the installed version insite-packages.As well as switching from flake8 to ruff, this PR also deletes thetest-requirements.txt; development dependencies are now listed in adevextra inpyproject.toml.