Merged
Conversation
Contributor
Author
|
Alternatively, this can be split into a skipped test. Let me know if you prefer that. |
Member
|
Thanks! Can you make it so that on 3.13 it asserts we get a TypeError? |
Contributor
Author
|
The if-ed block seems to be already tested in |
Contributor
Author
|
The |
Member
|
You're right. Let's just remove this block of tests, it duplicates |
This is a followup for d95cc22 The removed block raises TypeError on Python 3.13+. The TypeError is already asserted in test_keywords_syntax_raises_on_3_13. For older Pythons, the DeprecationWarning and __name__ + __annotations__ value are already asserted in test_typeddict_special_keyword_names.
Contributor
Author
|
Done. Explained the reasons for removal in the commit message. |
JelleZijlstra
approved these changes
Oct 18, 2023
Contributor
Author
|
Thanks for the quick feedback loop :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup for d95cc22