Skip to content

Annotated: backport bpo-46491#1049

Merged
JelleZijlstra merged 4 commits intopython:masterfrom
GBeauregard:backport-46491
Jan 25, 2022
Merged

Annotated: backport bpo-46491#1049
JelleZijlstra merged 4 commits intopython:masterfrom
GBeauregard:backport-46491

Conversation

@GBeauregard
Copy link
Copy Markdown
Contributor

This allows Annotated to wrap ClassVar and Final.

https://bugs.python.org/issue46491

Copy link
Copy Markdown
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just some small feedback

@JelleZijlstra
Copy link
Copy Markdown
Member

We could provide typing_extensions.Annotated on 3.9 and 3.10 to provide a version with the fix immediately, but I'm not sure that's worth it in this case. Alternatively, we can just skip the 3.9 and 3.10 tests until the next bugfix release.

@GBeauregard
Copy link
Copy Markdown
Contributor Author

We could provide typing_extensions.Annotated on 3.9 and 3.10 to provide a version with the fix immediately, but I'm not sure that's worth it in this case. Alternatively, we can just skip the 3.9 and 3.10 tests until the next bugfix release.

Is this okay?
@skipIf(sys.version_info[:2] in ((3, 9), (3, 10)), "Waiting for bugfix release.")

@JelleZijlstra
Copy link
Copy Markdown
Member

Yes, let's do that

@JelleZijlstra JelleZijlstra merged commit 3b53f01 into python:master Jan 25, 2022
@GBeauregard GBeauregard deleted the backport-46491 branch February 8, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants