boto: drop dependency on types-six#8792
Merged
JelleZijlstra merged 1 commit intopython:masterfrom Sep 26, 2022
Merged
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
approved these changes
Sep 26, 2022
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
Just to state explicitly what's going on here:
botoat runtime does, in fact, still usesixinternally- But typeshed only supports Python 3, and
six.http_clientis the same ashttp.clienton Python 3 - So that we can allow non-types dependencies without introducing a security hole, it's useful to ban stubs from having any dependencies if the runtime package they're stubs for doesn't also have that dependency. This applies to stub dependencies as well, since they're also now potentially dangerous given that stubs can now have non-stubs dependencies.
botodoesn't actually, officially, depend onsixat runtime, it just vendorssix. This means that the machinery in the stub-uploader can't detect thatbotousessixat runtime, ergotypes-botoalso cannot depend ontypes-six. And because of point (2) above, it's not a big deal to remove the dependency.
| @@ -1,2 +1,2 @@ | |||
| version = "2.49.*" | |||
| requires = ["types-six"] | |||
| requires = [] | |||
Member
There was a problem hiding this comment.
Suggested change
| requires = [] |
hauntsaninja
added a commit
to hauntsaninja/stub_uploader
that referenced
this pull request
Oct 11, 2022
Caused by a merge race with python/typeshed#8792
JelleZijlstra
pushed a commit
to typeshed-internal/stub_uploader
that referenced
this pull request
Oct 11, 2022
Caused by a merge race with python/typeshed#8792
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For typeshed-internal/stub_uploader#61 (comment)