Add @final to many unsubclassable stdlib classes#6299
Merged
srittau merged 1 commit intopython:masterfrom Nov 15, 2021
Merged
Conversation
srittau
approved these changes
Nov 15, 2021
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were all discovered using the following extremely crude script, the output of which I then manually checked:
The only results that this script produced that I have not added
@finalto aredict_keys,dict_valuesanddict_items(exposed incollections.abcat runtime, and inbuiltinsin typeshed). I couldn't add@finalto these classes because of the following weirdness:So, while these classes are not subclassable at runtime, they nonetheless have subclasses in the stdlib, meaning mypy understandably complains if I try to add
@finalto them.