Merged
Conversation
srittau
requested changes
Jun 16, 2021
Collaborator
srittau
left a comment
There was a problem hiding this comment.
Thank you. Could you also update the version in METADATA.toml? I think we should also remove python3 = false as this package supports Python 3 and the stubs seem fine. A few more remarks below.
srittau
requested changes
Jun 16, 2021
Collaborator
srittau
left a comment
There was a problem hiding this comment.
Thanks! I noticed one replace error below. Also, please replace Optional[X] with X | None (outside type aliases) and update the library version. Apart from that the changes look good.
srittau
reviewed
Jun 16, 2021
srittau
approved these changes
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2052.
OpenSSL.SSLOpenSSL.crypto_StrLikeand_BytesLikeannotations