Merged
Conversation
Crypto is a package that comes from pycrypto, which was last updated in 2013. It proudly supports Python 2.1 through 3.3. There's a near drop-in replacement from pycryptodome, which seems well maintained. pycryptodome has provided stubs for the last two years. I propose we get rid of the whole thing. pycrypto seems about as dead as software can get. These stubs have received two fixes since 2016. python#2952 https://pycryptodome.readthedocs.io/en/latest/src/vs_pycrypto.html https://github.com/Legrandin/pycryptodome/blob/master/Changelog.rst#371-25-november-2018
srittau
approved these changes
Oct 4, 2020
Collaborator
srittau
left a comment
There was a problem hiding this comment.
No need to keep it around. Obsolete libraries like this are still a maintenance burden for us.
Closed
JelleZijlstra
added a commit
to python/mypy
that referenced
this pull request
Jun 8, 2021
It doesn't exist, since it was removed from typeshed in October (python/typeshed#4606). Similarly, pynamodb was removed in January. I haven't tracked down what happened to pyre-extensions in typeshed, but https://pypi.org/project/types-pyre-extensions/ doesn't exist and in any case mypy users presumably don't need it.
JukkaL
pushed a commit
to python/mypy
that referenced
this pull request
Jun 9, 2021
It doesn't exist, since it was removed from typeshed in October (python/typeshed#4606). Similarly, pynamodb was removed in January. I haven't tracked down what happened to pyre-extensions in typeshed, but https://pypi.org/project/types-pyre-extensions/ doesn't exist and in any case mypy users presumably don't need it.
JukkaL
pushed a commit
to python/mypy
that referenced
this pull request
Jun 10, 2021
It doesn't exist, since it was removed from typeshed in October (python/typeshed#4606). Similarly, pynamodb was removed in January. I haven't tracked down what happened to pyre-extensions in typeshed, but https://pypi.org/project/types-pyre-extensions/ doesn't exist and in any case mypy users presumably don't need it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crypto is a package that comes from pycrypto, which was last updated in
2013. It proudly supports Python 2.1 through 3.3.
There's a near drop-in replacement from pycryptodome, which seems well
maintained. pycryptodome has provided stubs for the last two years.
I propose we get rid of the whole thing. pycrypto seems about as dead as
software can get. These stubs have received two fixes since 2016.
I've opened this PR for concreteness, but I anticipate that there might
be more discussion to be had :-)
Pros:
provides stubs. Typeshed has even received a bug report from
someone who couldn't install pycrypto: add PyCrypto for python 3.6 #1683
don't install whatever stubs we package
library, probably a good thing
Cons:
developing their well typed codebases utilising modern
cryptography libraries)
#2952
https://pycryptodome.readthedocs.io/en/latest/src/vs_pycrypto.html
https://github.com/Legrandin/pycryptodome/blob/master/Changelog.rst#371-25-november-2018