Conversation
|
The suite 'mypy self test' is failing with a very uninformative message |
CI had some issues https://travis-ci.org/python/typeshed/jobs/639617045 This also affected python#3636
|
Try forcing another CI build? Things seem to be working now, eg, for #3634 |
|
I restarted CI. |
|
Thank you - all green now. Ready for review. |
hauntsaninja
left a comment
There was a problem hiding this comment.
Lgtm.
bytes_object for pickle.loads should be named data, but that error precedes this PR.
One other weird note (that doesn't change anything) is that the docs say "If buffers is None (the default)" at https://docs.python.org/3/library/pickle.html#pickle.Unpickler, but for load and loads it looks like the default arg for buffers is empty tuple if it's using the version imported from _pickle.
srittau
left a comment
There was a problem hiding this comment.
Thanks, a few remarks below.
|
All comments implemented, with the exception of the () default for buffers where I feel the cpython implementation should be corrected |
The declaration was present twice. One from python#3358 with the bulk Python 3.8 support, the other from python#3636 with Pickle protocol 5 support.
The declaration was present twice. One from python#3358 with the bulk Python 3.8 support, the other from python#3636 with Pickle protocol 5 support.
Closes #3635