Revert __import__ function annotation to return type back to Any#3383
Merged
srittau merged 1 commit intopython:masterfrom Oct 17, 2019
ericvw:revert-__import__-to-return-Any
Merged
Revert __import__ function annotation to return type back to Any#3383srittau merged 1 commit intopython:masterfrom ericvw:revert-__import__-to-return-Any
srittau merged 1 commit intopython:masterfrom
ericvw:revert-__import__-to-return-Any
Conversation
srittau
requested changes
Oct 17, 2019
Collaborator
srittau
left a comment
There was a problem hiding this comment.
Changing the return type back to Any seems sensible, the other changes in the PR were ok, though. A straight revert is not the way to go here.
Contributor
Author
|
Oops — sorry about that. I got a bit overzealous and didn't realize there were other changes desired to keep. Let me fix that up. |
From python/mypy#7582. This partially reverts back the change in 0ee7c3c to have `__import__` return `Any` instead of `ModuleType`.
Contributor
Author
|
@srittau, thanks for pointing that out. The PR should be just addressing changing the return type back to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From python/mypy#7582.
This partially reverts back the change in
0ee7c3c to have
__import__returnAnyinstead ofModuleType.